Return MoltenVK log level string in pMessageIdName field of debug utils callback data #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhollings
reviewed
May 4, 2024
Use constexpr instead of inline const.
Hmmm...I'm not sure. It's kind of arbitrary, but |
billhollings
approved these changes
May 4, 2024
|
UPDATE: by changing to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2219.
Previously the
pMessageIdNamefield of debug utils callback data was set to nullptr, i.e. no messageId name. To provide more context and information to the user, we now fill this field with the MoltenVK log level string. This, combined with thepMessagestring, shows the severity of the message in textual form, and indicates that it comes from MoltenVK.Note I have changed the
mvkGetReportingLevelString()function declaration to inline - I hope this is appropriate.Also, after making this change I wonder whether it should also be applied to the debug report callback code, i.e. replace
_debugReportCallbackLayerPrefixwithmvkGetReportingLevelString()for consistency? I don't want to break anything re automated testing scripts, etc. so I didn't make this change yet. However, I think it's a question worth asking.